Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hsm2m.medium as valid type for hsm_type on aws_cloudhsm_v2_cluster #39206

Merged
merged 7 commits into from
Sep 10, 2024
Merged

Add hsm2m.medium as valid type for hsm_type on aws_cloudhsm_v2_cluster #39206

merged 7 commits into from
Sep 10, 2024

Conversation

prestonprice57
Copy link
Contributor

@prestonprice57 prestonprice57 commented Sep 6, 2024 •
edited
Loading

Description

Add hsm2m.medium as a valid hsm_type on aws_cloudhsm_v2_cluster. This new type has recently been released by Amazon.
Add mode as a property on aws_cloudhsm_v2_cluster. This property is required if hsm_type=hsm2m.medium

Relations

Closes 39018

References

AWS Blog announcement
AWS Docs

Output from Acceptance Testing

make testacc TESTS=TestAccCloudHSMV2 PKG=cloudhsmv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/cloudhsmv2/... -v -count 1 -parallel 20 -run='TestAccCloudHSMV2'  -timeout 360m
=== RUN   TestAccCloudHSMV2_serial
=== PAUSE TestAccCloudHSMV2_serial
=== CONT  TestAccCloudHSMV2_serial
=== RUN   TestAccCloudHSMV2_serial/Cluster
=== RUN   TestAccCloudHSMV2_serial/Cluster/basic
=== RUN   TestAccCloudHSMV2_serial/Cluster/disappears
=== RUN   TestAccCloudHSMV2_serial/Cluster/tags
=== RUN   TestAccCloudHSMV2_serial/Cluster/hsmType
=== RUN   TestAccCloudHSMV2_serial/Hsm
=== RUN   TestAccCloudHSMV2_serial/Hsm/availabilityZone
=== RUN   TestAccCloudHSMV2_serial/Hsm/basic
=== RUN   TestAccCloudHSMV2_serial/Hsm/disappears
=== RUN   TestAccCloudHSMV2_serial/Hsm/ipAddress
=== RUN   TestAccCloudHSMV2_serial/DataSource
=== RUN   TestAccCloudHSMV2_serial/DataSource/basic
--- PASS: TestAccCloudHSMV2_serial (5083.50s)
    --- PASS: TestAccCloudHSMV2_serial/Cluster (866.97s)
        --- PASS: TestAccCloudHSMV2_serial/Cluster/basic (242.38s)
        --- PASS: TestAccCloudHSMV2_serial/Cluster/disappears (265.64s)
        --- PASS: TestAccCloudHSMV2_serial/Cluster/tags (268.54s)
        --- PASS: TestAccCloudHSMV2_serial/Cluster/hsmType (90.39s)
    --- PASS: TestAccCloudHSMV2_serial/Hsm (3981.76s)
        --- PASS: TestAccCloudHSMV2_serial/Hsm/availabilityZone (1017.99s)
        --- PASS: TestAccCloudHSMV2_serial/Hsm/basic (1016.96s)
        --- PASS: TestAccCloudHSMV2_serial/Hsm/disappears (1003.89s)
        --- PASS: TestAccCloudHSMV2_serial/Hsm/ipAddress (942.91s)
    --- PASS: TestAccCloudHSMV2_serial/DataSource (234.78s)
        --- PASS: TestAccCloudHSMV2_serial/DataSource/basic (234.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudhsmv2	5092.937s

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service. needs-triage Waiting for first response or review from a maintainer. labels Sep 6, 2024
github-actions[bot]
github-actions bot reviewed Sep 7, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @prestonprice57 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@prestonprice57 prestonprice57 marked this pull request as ready for review September 9, 2024 19:22
@prestonprice57 prestonprice57 requested a review from a team as a code owner September 9, 2024 19:22
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Sep 10, 2024
@ewbankkit ewbankkit self-assigned this Sep 10, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 10, 2024
ewbankkit
ewbankkit approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccCloudHSMV2_serial/Cluster' PKG=cloudhsmv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/cloudhsmv2/... -v -count 1 -parallel 20  -run=TestAccCloudHSMV2_serial/Cluster -timeout 720m
=== RUN   TestAccCloudHSMV2_serial
=== PAUSE TestAccCloudHSMV2_serial
=== CONT  TestAccCloudHSMV2_serial
=== RUN   TestAccCloudHSMV2_serial/Cluster
=== RUN   TestAccCloudHSMV2_serial/Cluster/basic
=== RUN   TestAccCloudHSMV2_serial/Cluster/disappears
=== RUN   TestAccCloudHSMV2_serial/Cluster/tags
=== RUN   TestAccCloudHSMV2_serial/Cluster/hsmType
--- PASS: TestAccCloudHSMV2_serial (842.01s)
    --- PASS: TestAccCloudHSMV2_serial/Cluster (842.01s)
        --- PASS: TestAccCloudHSMV2_serial/Cluster/basic (234.07s)
        --- PASS: TestAccCloudHSMV2_serial/Cluster/disappears (262.04s)
        --- PASS: TestAccCloudHSMV2_serial/Cluster/tags (264.53s)
        --- PASS: TestAccCloudHSMV2_serial/Cluster/hsmType (81.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudhsmv2	847.092s

@ewbankkit
Copy link
Contributor

@prestonprice57 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ac7588d into hashicorp:main Sep 10, 2024
40 checks passed
@github-actions github-actions bot added this to the v5.67.0 milestone Sep 10, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 13, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2024
@prestonprice57 prestonprice57 deleted the f-update-cloudhsm-cluster-type branch October 14, 2024 17:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.67.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_cloudhsm_v2_cluster - add support for hsm2m.medium hsm_type
2 participants
@prestonprice57 @ewbankkit